From 494061f59b747ce6cdeb293286bb8a8ec6179c7a Mon Sep 17 00:00:00 2001 From: Tobias Pietzsch <tobias.pietzsch@gmail.com> Date: Fri, 13 Feb 2015 01:13:28 +0100 Subject: [PATCH] disable the "-m" option (ManagerHandler) by default. To enable, build with Constants.ENABLE_EXPERIMENTAL_FEATURES=true. --- src/main/java/bdv/server/BigDataServer.java | 20 +++++++++++++++----- src/main/java/bdv/server/Constants.java | 2 ++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/main/java/bdv/server/BigDataServer.java b/src/main/java/bdv/server/BigDataServer.java index 626d131..81c87a0 100644 --- a/src/main/java/bdv/server/BigDataServer.java +++ b/src/main/java/bdv/server/BigDataServer.java @@ -40,8 +40,12 @@ import java.util.Map.Entry; * per line. Each line is formatted as "NAME <TAB> XML". * -p <PORT> Listening port. (default: 8080) * -s <HOSTNAME> Hostname of the server. + * -m enable statistics and manager context. EXPERIMENTAL! * </pre> * + * To enable the {@code -m} option, build with + * {@link Constants#ENABLE_EXPERIMENTAL_FEATURES} set to {@code true}. + * * @author Tobias Pietzsch <tobias.pietzsch@gmail.com> * @author HongKee Moon <moon@mpi-cbg.de> */ @@ -201,9 +205,12 @@ public class BigDataServer .withArgName( "FILE" ) .create( "d" ) ); - options.addOption( OptionBuilder - .withDescription( "enable statistics and manager context. EXPERIMENTAL!" ) - .create( "m" ) ); + if ( Constants.ENABLE_EXPERIMENTAL_FEATURES ) + { + options.addOption( OptionBuilder + .withDescription( "enable statistics and manager context. EXPERIMENTAL!" ) + .create( "m" ) ); + } try { @@ -221,8 +228,11 @@ public class BigDataServer final HashMap< String, String > datasets = new HashMap< String, String >( defaultParameters.getDatasets() ); boolean enableManagerContext = false; - if ( cmd.hasOption( "m" ) ) - enableManagerContext = true; + if ( Constants.ENABLE_EXPERIMENTAL_FEATURES ) + { + if ( cmd.hasOption( "m" ) ) + enableManagerContext = true; + } if ( cmd.hasOption( "d" ) ) { diff --git a/src/main/java/bdv/server/Constants.java b/src/main/java/bdv/server/Constants.java index d4a1419..9a8036f 100644 --- a/src/main/java/bdv/server/Constants.java +++ b/src/main/java/bdv/server/Constants.java @@ -15,4 +15,6 @@ public class Constants public static final int THUMBNAIL_WIDTH = 100; public static final int THUMBNAIL_HEIGHT = 100; + + public static final boolean ENABLE_EXPERIMENTAL_FEATURES = false; } -- GitLab