From 5aca292f8f49cc5cc50f7aa6db6b6687035aa0ab Mon Sep 17 00:00:00 2001 From: Vojtech Moravec <vojtech.moravec.st@vsb.cz> Date: Tue, 18 Feb 2020 18:02:21 +0100 Subject: [PATCH] Read magic value outside of assert. --- src/main/java/azgracompress/fileformat/QCMPFileHeader.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/azgracompress/fileformat/QCMPFileHeader.java b/src/main/java/azgracompress/fileformat/QCMPFileHeader.java index 9944d72..80da098 100644 --- a/src/main/java/azgracompress/fileformat/QCMPFileHeader.java +++ b/src/main/java/azgracompress/fileformat/QCMPFileHeader.java @@ -78,7 +78,11 @@ public class QCMPFileHeader { } byte[] magicBuffer = new byte[QCMP_MAGIC_VALUE.length()]; - assert (inputStream.readNBytes(magicBuffer, 0, QCMP_MAGIC_VALUE.length()) == QCMP_MAGIC_VALUE.length()); + final int readFromMagic = inputStream.readNBytes(magicBuffer, 0, QCMP_MAGIC_VALUE.length()); + if (readFromMagic != QCMP_MAGIC_VALUE.length()) { + // Invalid magic value. + return false; + } magicValue = new String(magicBuffer); if (!magicValue.equals(QCMP_MAGIC_VALUE)) { -- GitLab