From 0c21df4e49166d7aa0b7606db0f9e34ab93a7b68 Mon Sep 17 00:00:00 2001
From: Campbell Barton <ideasman42@gmail.com>
Date: Tue, 15 Oct 2019 19:42:17 +1100
Subject: [PATCH] Add warnings about non-compliant imports
This makes code harder to maintain & should be resolved
since this add-on is now on by default.
---
io_scene_gltf2/io/com/gltf2_io_lights_punctual.py | 2 +-
io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
index 3dc8704cc..fe29ebc32 100644
--- a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
+++ b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
@@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# FIXME, this goes against Blender's best practice.
from io_scene_gltf2.io.com.gltf2_io import *
@@ -73,4 +74,3 @@ class Light:
self.extensions)
result["extras"] = self.extras
return result
-
diff --git a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
index 2d42ce10c..0230bdfc5 100644
--- a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
+++ b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
@@ -14,7 +14,10 @@
import bpy
import sys
+
+# FIXME, this goes against Blender's best practice.
from ctypes import *
+
from pathlib import Path
from io_scene_gltf2.io.exp.gltf2_io_binary_data import BinaryData
@@ -240,4 +243,3 @@ def __compress_primitive(primitive, dll, export_settings):
dll.disposeCompressor(compressor)
pass
-
--
GitLab