From 5fd8bdb7dc0a1c1e59d25d94f2d276a6a48b54fb Mon Sep 17 00:00:00 2001
From: Campbell Barton <ideasman42@gmail.com>
Date: Thu, 4 Apr 2013 18:25:22 +0000
Subject: [PATCH] resolve issues reported by dolf. (but not all)
1. Don't zoom out when selecting output. Often you want to recheck an area you're working on... and you have to zoom back in again and again.
3. The distorted check is a great tool.. I have the default value at 45 degrees... I think you had it at 15? That's a bit low.
4. The upper limit for thickness check needs to be much higher. If you're working in mm 1 is too low (coloured prints have a lower limit of 2mm)... so make the limit for the check 10 or so.
5. Sharp edge check seems to work for both negative and positive values. There is very much a difference between those when printing... You're usually looking for pointy stuff.
---
object_print3d_utils/__init__.py | 4 ++--
object_print3d_utils/operators.py | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/object_print3d_utils/__init__.py b/object_print3d_utils/__init__.py
index 3dbec458d..f638d598d 100644
--- a/object_print3d_utils/__init__.py
+++ b/object_print3d_utils/__init__.py
@@ -76,7 +76,7 @@ class Print3DSettings(PropertyGroup):
description="Minimum thickness",
subtype='DISTANCE',
default=0.001, # 1mm
- min=0.0, max=1.0,
+ min=0.0, max=10.0,
)
threshold_zero = FloatProperty(
name="Threshold",
@@ -89,7 +89,7 @@ class Print3DSettings(PropertyGroup):
name="Angle",
description="Limit for checking distorted faces",
subtype='ANGLE',
- default=math.radians(15.0),
+ default=math.radians(45.0),
min=0.0, max=math.radians(180.0),
)
angle_sharp = FloatProperty(
diff --git a/object_print3d_utils/operators.py b/object_print3d_utils/operators.py
index 382eb1355..76d2dc6e4 100644
--- a/object_print3d_utils/operators.py
+++ b/object_print3d_utils/operators.py
@@ -256,7 +256,7 @@ class Print3DCheckSharp(Operator):
bm.normal_update()
edges_sharp = [ele.index for ele in bm.edges
- if ele.is_manifold and ele.calc_face_angle() > angle_sharp]
+ if ele.is_manifold and ele.calc_face_angle_signed() > angle_sharp]
info.append(("Sharp Edge: %d" % len(edges_sharp),
(bmesh.types.BMEdge, edges_sharp)))
@@ -482,8 +482,8 @@ class Print3DSelectReport(Operator):
# possible arrays are out of sync
self.report({'WARNING'}, "Report is out of date, re-run check")
- # Perhaps this is annoying? but also handy!
- bpy.ops.view3d.view_selected(use_all_regions=False)
+ # cool, but in fact annoying
+ #~ bpy.ops.view3d.view_selected(use_all_regions=False)
return {'FINISHED'}
--
GitLab