From 7c0d4de11721bd93afc64e0cf63cc84807c5c305 Mon Sep 17 00:00:00 2001
From: Julien Duroure <julien.duroure@gmail.com>
Date: Mon, 19 Sep 2022 08:48:45 +0200
Subject: [PATCH] glTF exporter: Fix default sheen factors
---
io_scene_gltf2/__init__.py | 2 +-
.../blender/exp/gltf2_blender_gather_materials_sheen.py | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/io_scene_gltf2/__init__.py b/io_scene_gltf2/__init__.py
index f0f71dfce..fba51d41f 100755
--- a/io_scene_gltf2/__init__.py
+++ b/io_scene_gltf2/__init__.py
@@ -4,7 +4,7 @@
bl_info = {
'name': 'glTF 2.0 format',
'author': 'Julien Duroure, Scurest, Norbert Nopper, Urs Hanselmann, Moritz Becher, Benjamin SchmithĂĽsen, Jim Eckerlein, and many external contributors',
- "version": (3, 4, 11),
+ "version": (3, 4, 12),
'blender': (3, 3, 0),
'location': 'File > Import-Export',
'description': 'Import-Export as glTF 2.0',
diff --git a/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py b/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
index 03625ecbc..1d4fb5b93 100644
--- a/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
+++ b/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
@@ -29,6 +29,8 @@ def export_sheen(blender_material, export_settings):
else:
# Factor
fac = gltf2_blender_get.get_factor_from_socket(sheenColor_socket, kind='RGB')
+ if fac is None:
+ fac = [1.0, 1.0, 1.0] # Default is 0.0/0.0/0.0, so we need to set it to 1 if no factor
if fac is not None and fac != [0.0, 0.0, 0.0]:
sheen_extension['sheenColorFactor'] = fac
@@ -51,6 +53,8 @@ def export_sheen(blender_material, export_settings):
else:
# Factor
fac = gltf2_blender_get.get_factor_from_socket(sheenRoughness_socket, kind='VALUE')
+ if fac is None:
+ fac = 1.0 # Default is 0.0 so we need to set it to 1.0 if no factor
if fac is not None and fac != 0.0:
sheen_extension['sheenRoughnessFactor'] = fac
--
GitLab