From f05763b347926198316aae24938914c1de7560a7 Mon Sep 17 00:00:00 2001
From: Maurice Raybaud <mauriceraybaud@hotmail.fr>
Date: Thu, 26 Mar 2020 20:52:56 +0100
Subject: [PATCH] render_povray * removed charset : The `charset` global
 setting has been deprecated in pov 3.8. Input files conforming to ASCII,
 UTF-8, Latin-1 or Windows-1252 encoding will instead be auto-detected, while
 other encodings are currently unsupported.

---
 render_povray/__init__.py | 22 +++++++++++-----------
 render_povray/render.py   |  5 +++--
 render_povray/ui.py       |  3 ++-
 3 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/render_povray/__init__.py b/render_povray/__init__.py
index 5080aab96..7a6332ee8 100644
--- a/render_povray/__init__.py
+++ b/render_povray/__init__.py
@@ -579,17 +579,17 @@ class RenderPovSettingsScene(PropertyGroup):
         options={'ANIMATABLE'},
         subtype='COLOR'
     )
-
-    charset: EnumProperty(
-        name="Charset",
-        description="This allows you to specify the assumed character set of all text strings",
-        items=(
-            ("ascii", "ASCII", ""),
-            ("utf8", "UTF-8", ""),
-            ("sys", "SYS", "")
-        ),
-        default="utf8",
-    )
+    # Deprecated (autodetected in pov3.8):
+    # charset: EnumProperty(
+        # name="Charset",
+        # description="This allows you to specify the assumed character set of all text strings",
+        # items=(
+            # ("ascii", "ASCII", ""),
+            # ("utf8", "UTF-8", ""),
+            # ("sys", "SYS", "")
+        # ),
+        # default="utf8",
+    # )
 
     max_intersections_enable: BoolProperty(
         name="Enable",
diff --git a/render_povray/render.py b/render_povray/render.py
index e6c1b01b8..afae0981b 100644
--- a/render_povray/render.py
+++ b/render_povray/render.py
@@ -4747,8 +4747,9 @@ def write_pov(filename, scene=None, info_callback=None):
         tabWrite("assumed_gamma 1.0\n")
         tabWrite("max_trace_level %d\n" % scene.pov.max_trace_level)
 
-        if scene.pov.charset != 'ascii':
-            file.write("    charset %s\n" % scene.pov.charset)
+        # Deprecated (autodetected in pov3.8):
+        # if scene.pov.charset != 'ascii':
+            # file.write("    charset %s\n" % scene.pov.charset)
         if scene.pov.global_settings_advanced:
             if scene.pov.radio_enable == False:
                 file.write("    adc_bailout %.6f\n" % scene.pov.adc_bailout)
diff --git a/render_povray/ui.py b/render_povray/ui.py
index 49bcda3ac..e15a93741 100644
--- a/render_povray/ui.py
+++ b/render_povray/ui.py
@@ -1203,7 +1203,8 @@ class RENDER_PT_POV_render_settings(RenderButtonsPanel, Panel):
         col.prop(scene.pov, "max_trace_level", text="Ray Depth")
         align = True
         layout.active = scene.pov.global_settings_advanced
-        layout.prop(scene.pov, "charset")
+        # Deprecated (autodetected in pov3.8):
+        # layout.prop(scene.pov, "charset")
         row = layout.row(align=align)
         row.prop(scene.pov, "adc_bailout")
         row = layout.row(align=align)
-- 
GitLab