diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/BenchmarkJobManager.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/BenchmarkJobManager.java index ac88a8b9c9fa8bc070b4b3c67110c4a850aa7518..f6b5f029e0f69b62a997ea24c8e1870b3d9be899 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/BenchmarkJobManager.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/BenchmarkJobManager.java @@ -261,7 +261,7 @@ public class BenchmarkJobManager { for (int i = 1; i < columns.length; i++) { values.add(new ResultFileJob(columns[i])); } - } else if (!columns[0].equals("jobs #")){ + } else if (!columns[0].equals("jobs #")) { for (int i = 1; i < columns.length; i++) { ResultFileJob resultFileJob; resultFileJob = values.get(i - 1); diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/Constants.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/Constants.java index 0c722e146e8fbe5311fdefdb718f940905591bdd..65124a7cbb19c135843f48ae8307a229bfa30c85 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/Constants.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/Constants.java @@ -11,4 +11,8 @@ public interface Constants { String SPIM_OUTPUT_FILENAME_PATTERN = "spim.outputFilenamePattern"; String CONFIG_YAML = "config.yaml"; String BENCHMARK_RESULT_FILE = "benchmark_result.csv"; + + String STATISTICS_RESOURCES_MEMORY_USAGE = "resources_used.mem"; + String STATISTICS_RESOURCES_WALL_TIME = "resources_used.walltime"; + String STATISTICS_RESOURCES_CPU_PERCENTAGE = "resources_used.cpupercent"; } diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileJob.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileJob.java index eb6f5c4ef4e182035a7b6b070d1fffc093cb0cb0..f67fee23997feb9a8782eab46e65ebd43e1b7a21 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileJob.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileJob.java @@ -9,7 +9,6 @@ public class ResultFileJob { public ResultFileJob(String id) { this.id = id; - } public String getValue(String key) { diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileTask.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileTask.java index 8ec16a0d59a724e7c0716368d8e6d788d4b9e2f6..88767ed9748b70ddd2cf921d2733e05e7b73824d 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileTask.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/ResultFileTask.java @@ -1,8 +1,6 @@ package cz.it4i.fiji.haas_spim_benchmark.core; import java.util.LinkedList; -import java.util.function.Function; -import java.util.stream.Collector; import java.util.stream.Collectors; public class ResultFileTask { @@ -19,23 +17,20 @@ public class ResultFileTask { } public double getAverageMemoryUsage() { - return getAverage(str->Double.parseDouble(str), Collectors.averagingDouble(d->d),"resources_used.mem").doubleValue(); + return getAverage(Constants.STATISTICS_RESOURCES_MEMORY_USAGE); } public double getAverageWallTime() { - return getAverage("resources_used.walltime"); + return getAverage(Constants.STATISTICS_RESOURCES_WALL_TIME); } public double getAverageCpuPercentage() { - return getAverage("resources_used.cpupercent"); - } - - private double getAverage(String propertyName) { - return getAverage(str->Integer.parseInt(str), Collectors.averagingInt(i->i),propertyName).doubleValue(); + return getAverage(Constants.STATISTICS_RESOURCES_CPU_PERCENTAGE); } - private<T> Double getAverage(Function<String, T> valueProvider,Collector<T,?,Double> collector,String propertyName) { - return jobs.stream().map(job -> job.getValue(propertyName)).map(memStr -> valueProvider.apply(memStr)) - .collect(collector); + private Double getAverage(String propertyName) { + return jobs.stream().map(job -> job.getValue(propertyName)) + .map(memStr -> Double.parseDouble(memStr)) + .collect(Collectors.averagingDouble(d->d)).doubleValue(); } } \ No newline at end of file