From f541fa55a52231fd1589bb1318c19332555f3904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Ko=C5=BEusznik?= <jan@kozusznik.cz> Date: Fri, 9 Mar 2018 10:23:31 +0100 Subject: [PATCH] docs: change TASK to FIXME and revise --- .../java/cz/it4i/fiji/haas_java_client/HaaSFileTransferImp.java | 2 +- .../cz/it4i/fiji/haas_spim_benchmark/core/TaskComputation.java | 1 + .../fiji/haas_spim_benchmark/ui/BenchmarkSPIMController.java | 2 +- .../fiji/haas_spim_benchmark/ui/TaskComputationAdapter.java | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/haas-java-client/src/main/java/cz/it4i/fiji/haas_java_client/HaaSFileTransferImp.java b/haas-java-client/src/main/java/cz/it4i/fiji/haas_java_client/HaaSFileTransferImp.java index c48e2e04..5cbaf90c 100644 --- a/haas-java-client/src/main/java/cz/it4i/fiji/haas_java_client/HaaSFileTransferImp.java +++ b/haas-java-client/src/main/java/cz/it4i/fiji/haas_java_client/HaaSFileTransferImp.java @@ -104,7 +104,7 @@ class HaaSFileTransferImp implements HaaSFileTransfer { } - // TASK merge with download - stream provider for file, consumer for stream + // FIXME: merge with download - stream provider for file, consumer for stream @Override public List<String> getContent(List<String> files) { List<String> result = new LinkedList<>(); diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/TaskComputation.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/TaskComputation.java index 0c4d3925..4aacf630 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/TaskComputation.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/core/TaskComputation.java @@ -16,6 +16,7 @@ import com.google.common.collect.Streams; import cz.it4i.fiji.haas_java_client.JobState; import cz.it4i.fiji.haas_java_client.SynchronizableFileType; +//FIXME: TaskComputation 'done' should be Finished not Queued public class TaskComputation { public static class Log { diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/BenchmarkSPIMController.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/BenchmarkSPIMController.java index f37db8a9..2dd990df 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/BenchmarkSPIMController.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/BenchmarkSPIMController.java @@ -41,7 +41,7 @@ import javafx.scene.control.TableView; import javafx.scene.layout.BorderPane; import net.imagej.updater.util.Progress; -//TASK: fix Exception during context menu request on task with N/A state +//FIXME: fix Exception during context menu request on task with N/A state public class BenchmarkSPIMController extends BorderPane implements CloseableControl, InitiableControl { @FXML diff --git a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/TaskComputationAdapter.java b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/TaskComputationAdapter.java index 5b2d5efc..40c7fa85 100644 --- a/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/TaskComputationAdapter.java +++ b/haas-spim-benchmark/src/main/java/cz/it4i/fiji/haas_spim_benchmark/ui/TaskComputationAdapter.java @@ -16,7 +16,7 @@ import cz.it4i.fiji.haas_spim_benchmark.core.TaskComputation; import cz.it4i.fiji.haas_spim_benchmark.core.TaskComputation.Log; import javafx.beans.value.ObservableValue; import javafx.beans.value.ObservableValueBase; -//TASK: improve performance + public class TaskComputationAdapter implements Closeable { public final static Logger log = LoggerFactory -- GitLab