From d320ceb5482e79af757d6d2ed8dcbbc55f2f4aec Mon Sep 17 00:00:00 2001 From: Marek Chrastina <marek.chrastina@vsb.cz> Date: Thu, 30 May 2019 10:30:28 +0200 Subject: [PATCH] Make pylint happy --- pipupgradedependencies/__init__.py | 3 +++ .../pipupgradedependencies.py | 20 +++++++++++-------- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/pipupgradedependencies/__init__.py b/pipupgradedependencies/__init__.py index de40ea7..06e9293 100644 --- a/pipupgradedependencies/__init__.py +++ b/pipupgradedependencies/__init__.py @@ -1 +1,4 @@ +""" +pipupgradedependencies init +""" __import__('pkg_resources').declare_namespace(__name__) diff --git a/pipupgradedependencies/pipupgradedependencies.py b/pipupgradedependencies/pipupgradedependencies.py index 19c0a5c..e117509 100644 --- a/pipupgradedependencies/pipupgradedependencies.py +++ b/pipupgradedependencies/pipupgradedependencies.py @@ -1,3 +1,6 @@ +""" +pipupgradedependencies +""" import argparse import json import os @@ -7,19 +10,20 @@ import sys def find_dependencies(json_input, package): if isinstance(json_input, dict): - keys = json_input.keys() - if 'package_name' in keys and 'required_version' in keys: - if re.search(r'^%s$' % package, json_input['package_name'], re.IGNORECASE): - yield json_input['required_version'] + keys = json_input.keys() + if 'package_name' in keys and 'required_version' in keys: + if re.search(r'^%s$' % package, json_input['package_name'], re.IGNORECASE): + yield json_input['required_version'] for child_val in find_dependencies(json_input['dependencies'], package): yield child_val elif isinstance(json_input, list): for item in json_input: for item_val in find_dependencies(item, package): yield item_val + def arg_parse(): parser = argparse.ArgumentParser(description="Pipupgradedependencies upgrades all outdated packages with respect to existing dependencies.") - parser_args = parser.parse_args() + parser.parse_args() def main(): arg_parse() @@ -49,10 +53,10 @@ def main(): for package in outdated_packages: if package in finished_upgrades: continue - package_dependencies = [ _ for _ in find_dependencies(jsonpipdeptree, package)] + package_dependencies = [_ for _ in find_dependencies(jsonpipdeptree, package)] package_dependencies = list(set(package_dependencies)) - if len(filter(lambda dependency: re.search(r'(^==.*|^\d.*)', dependency), package_dependencies)) == 0: - possible_upgrades.append({'package': package, 'dependencies': [ dependency for dependency in package_dependencies if 'Any' not in dependency]}) + if not [dependency for dependency in package_dependencies if re.search(r'(^==.*|^\d.*)', dependency) is not None]: + possible_upgrades.append({'package': package, 'dependencies': [dependency for dependency in package_dependencies if 'Any' not in dependency]}) try: package = possible_upgrades[-1] -- GitLab