Skip to content
Snippets Groups Projects
Commit f4dc9f9d authored by Sybren A. Stüvel's avatar Sybren A. Stüvel
Browse files

Fix T54360: FFMPEG bitrate not editable for all codecs

The bitrate selection was hidden when a CRF mode was chosen and then
switched to a codec that doesn't support CRF.
parent 6f07673c
Branches
Tags
No related merge requests found
...@@ -473,7 +473,8 @@ class RENDER_PT_encoding(RenderButtonsPanel, Panel): ...@@ -473,7 +473,8 @@ class RENDER_PT_encoding(RenderButtonsPanel, Panel):
layout.prop(ffmpeg, "use_lossless_output") layout.prop(ffmpeg, "use_lossless_output")
# Output quality # Output quality
if needs_codec and ffmpeg.codec in {'H264', 'MPEG4'}: use_crf = needs_codec and ffmpeg.codec in {'H264', 'MPEG4'}
if use_crf:
layout.prop(ffmpeg, "constant_rate_factor") layout.prop(ffmpeg, "constant_rate_factor")
# Encoding speed # Encoding speed
...@@ -488,7 +489,7 @@ class RENDER_PT_encoding(RenderButtonsPanel, Panel): ...@@ -488,7 +489,7 @@ class RENDER_PT_encoding(RenderButtonsPanel, Panel):
pbox.enabled = ffmpeg.use_max_b_frames pbox.enabled = ffmpeg.use_max_b_frames
split = layout.split() split = layout.split()
split.enabled = ffmpeg.constant_rate_factor == 'NONE' split.enabled = not use_crf or ffmpeg.constant_rate_factor == 'NONE'
col = split.column() col = split.column()
col.label(text="Rate:") col.label(text="Rate:")
col.prop(ffmpeg, "video_bitrate") col.prop(ffmpeg, "video_bitrate")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment