Skip to content
Snippets Groups Projects
Commit 5fd8bdb7 authored by Campbell Barton's avatar Campbell Barton
Browse files

resolve issues reported by dolf.

(but not all)

1. Don't zoom out when selecting output. Often you want to recheck an area you're working on... and you have to zoom back in again and again.

3. The distorted check is a great tool.. I have the default value at 45 degrees... I think you had it at 15? That's a bit low.

4. The upper limit for thickness check needs to be much higher. If you're working in mm 1 is too low (coloured prints have a lower limit of 2mm)... so make the limit for the check 10 or so.

5. Sharp edge check seems to work for both negative and positive values. There is very much a difference between those when printing... You're usually looking for pointy stuff.
parent 2e3a36f9
No related branches found
No related tags found
No related merge requests found
...@@ -76,7 +76,7 @@ class Print3DSettings(PropertyGroup): ...@@ -76,7 +76,7 @@ class Print3DSettings(PropertyGroup):
description="Minimum thickness", description="Minimum thickness",
subtype='DISTANCE', subtype='DISTANCE',
default=0.001, # 1mm default=0.001, # 1mm
min=0.0, max=1.0, min=0.0, max=10.0,
) )
threshold_zero = FloatProperty( threshold_zero = FloatProperty(
name="Threshold", name="Threshold",
...@@ -89,7 +89,7 @@ class Print3DSettings(PropertyGroup): ...@@ -89,7 +89,7 @@ class Print3DSettings(PropertyGroup):
name="Angle", name="Angle",
description="Limit for checking distorted faces", description="Limit for checking distorted faces",
subtype='ANGLE', subtype='ANGLE',
default=math.radians(15.0), default=math.radians(45.0),
min=0.0, max=math.radians(180.0), min=0.0, max=math.radians(180.0),
) )
angle_sharp = FloatProperty( angle_sharp = FloatProperty(
......
...@@ -256,7 +256,7 @@ class Print3DCheckSharp(Operator): ...@@ -256,7 +256,7 @@ class Print3DCheckSharp(Operator):
bm.normal_update() bm.normal_update()
edges_sharp = [ele.index for ele in bm.edges edges_sharp = [ele.index for ele in bm.edges
if ele.is_manifold and ele.calc_face_angle() > angle_sharp] if ele.is_manifold and ele.calc_face_angle_signed() > angle_sharp]
info.append(("Sharp Edge: %d" % len(edges_sharp), info.append(("Sharp Edge: %d" % len(edges_sharp),
(bmesh.types.BMEdge, edges_sharp))) (bmesh.types.BMEdge, edges_sharp)))
...@@ -482,8 +482,8 @@ class Print3DSelectReport(Operator): ...@@ -482,8 +482,8 @@ class Print3DSelectReport(Operator):
# possible arrays are out of sync # possible arrays are out of sync
self.report({'WARNING'}, "Report is out of date, re-run check") self.report({'WARNING'}, "Report is out of date, re-run check")
# Perhaps this is annoying? but also handy! # cool, but in fact annoying
bpy.ops.view3d.view_selected(use_all_regions=False) #~ bpy.ops.view3d.view_selected(use_all_regions=False)
return {'FINISHED'} return {'FINISHED'}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment